RE: [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4 devices
From: Claudiu Manoil
Date: Thu Oct 15 2026 - 09:39:11 EST
NXP Confidential
> From: Wei Fang <wei.fang@xxxxxxx>
> Sent: Thursday, October 15, 2026 4:42 AM
[...]
> Subject: RE: [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4
> devices
>
> > + { .revision = ENETC_REV_4_4,
> > + .dev_id = NXP_ENETC_PPM_DEV_ID,
> > + .data = &enetc4_ppm_data,
> > + },
>
> You have reused driver data of the i.MX94, which has a system clock
> frequency of 333 MHz. However, for the S32N7, I think its system
> clock frequency to be 500 MHz. And the system clock frequency is
> used for DIM. Therefore, you'd better to add the new driver data
> for S32N7.
>
Ok, wanted to deal with the NETC frequency of S32N79 later, but I'll
look into adding this info in v3. This is not a functional issue, the driver
still works with the 'old' frequency, but it may affect indeed the performance
of interrupt coalescing.