Re: [PATCH v3] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[Alex Elder]

On 10/14/26 9:07 PM, Jeremy Dean Clifton wrote:
> Commit 3228900f80c2 ("staging: greybus: Remove unused function
> 'to_fw_mgmt_connection'") removed a function definition but did not
> remove the function prototype.
>
> Remove the prototype.
>
> Signed-off-by: Jeremy Dean Clifton <deaner92@xxxxxxxxx>

This could maybe have a "fixes" but if it gets accepted soon
I don't think it will matter, because this will land in the
same release as the fixed commit.

This looks good.

Reviewed-by: Alex Elder <elder@xxxxxxxxxxxx>

> ---
> v3: Change to imperative mood and write in proper English (Julia
> Lawall).
> v2: Fix grammar and spelling in commit message.
>
>   drivers/staging/greybus/firmware.h | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h
> index 5d2564462ffc..04a67d2d5b8f 100644
> --- a/drivers/staging/greybus/firmware.h
> +++ b/drivers/staging/greybus/firmware.h
> @@ -22,7 +22,6 @@
>   /* Firmware Management Protocol specific functions */
>   int fw_mgmt_init(void);
>   void fw_mgmt_exit(void);
> -struct gb_connection *to_fw_mgmt_connection(struct device *dev);
>   int gb_fw_mgmt_request_handler(struct gb_operation *op);
>   int gb_fw_mgmt_connection_init(struct gb_connection *connection);
>   void gb_fw_mgmt_connection_exit(struct gb_connection *connection);