Re: [PATCH v2 7/7] mfd: qcom-pm8008: Tolerate missing interrupt

[Konrad Dybcio]

On 10/14/26 12:32 PM, Jishnu Prakash wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> 
> PM8010 is often wired up with the interrupt pin tied to ground. Only
> register the IRQ infrastructure if we have a parent irq.
> 
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Co-developed-by: Dhruvin Rajpura <drajpura@xxxxxxxxxxxxxxxx>
> Signed-off-by: Dhruvin Rajpura <drajpura@xxxxxxxxxxxxxxxx>
> Co-developed-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> ---
>  drivers/mfd/qcom-pm8008.c | 82 ++++++++++++++++++++++++++++++++++-------------
>  1 file changed, 60 insertions(+), 22 deletions(-)
> 
> diff --git a/drivers/mfd/qcom-pm8008.c b/drivers/mfd/qcom-pm8008.c
> index 4179427f3891..8b1bbb4052a7 100644
> --- a/drivers/mfd/qcom-pm8008.c
> +++ b/drivers/mfd/qcom-pm8008.c
> @@ -208,6 +208,14 @@ static const struct mfd_cell pm8010_cells[] = {
>  	MFD_CELL_RES("qpnp-temp-alarm", pm8008_temp_res),
>  };
>  
> +static const struct mfd_cell pm8008_no_irq_cells[] = {
> +	MFD_CELL_NAME("pm8008-regulator"),

There's no reason to not register the temperature alarm driver
if we don't have an irq. It will not be able to carry out the
"alarm" part, but one can still poll on it.

Konrad