Re: [PATCH v1 3/4] platform profile: Add firmware-neutral aggregate sysfs interface

[Rafael J. Wysocki (Intel)]

On Wed, Oct 14, 2026 at 11:31 PM Armin Wolf <W_Armin@xxxxxx> wrote:
>
> Am 14.10.26 um 15:24 schrieb Daniel Lezcano:
>
> > The per-provider class interface is firmware-independent, but system-
> > wide profile selection is only exposed under /sys/firmware/acpi.
> >
> > Add /sys/kernel/platform_profile/{choices,profile}, sharing the existing
> > aggregate callbacks and semantics with the legacy interface. Keep
> > attributes hidden until a provider is registered and remove them after
> > the last provider.
> >
> > Notify both aggregate frontends on profile changes. Also notify the
> > provider class device on a direct profile write, matching its documented
> > POLLPRI ABI. Restore aggregate visibility after a failed registration.
>
> IMHO the aggregate sysfs interface only exists for backwards-compatibility,
> so i would be very happy if you could just make the associated code optional
> and instead teach platform-profiles-daemon to use the individual class devices
> instead.

It is not just a matter of opinion AFAICS, the aggregate interface has
been regarded as legacy for quite a while (see commit 778b94d7ac17
"ACPI: platform_profile: Add support for hidden choices" for example)
and it was retained exactly for backwards compatibility reasons IIRC.

I'm with Armin on this.

Thanks!