Re: [PATCH v2 1/2] dt-bindings: input: add OnePlus pogo-pin keyboard

From: wyibo6109

Date: Thu Oct 15 2026 - 07:19:53 EST


From: Yibo Wang <wyibo6109@xxxxxxxxx>

Hi Krzysztof,

On Wed, Oct 14, 2026 at ... Krzysztof Kozlowski wrote:
> I don't think we are describing here the MCU, but the keyboard, thus
> it's physical geometry is fixed.

Agreed - the node binds the keyboard, and a keyboard's geometry is
fixed with the hardware. That is exactly why v3 does not describe it
in DT at all: the touchpad geometry and the product names are
per-compatible constants in the driver's match data. I also reworded
the binding to describe the keyboard (built around the Tinno MCU)
rather than the MCU itself, and the touchscreen properties remain only
as an optional override for the unlikely case of a variant.

The rewording will be folded into v4, which follows as a reply to
the v3 cover letter.

Best regards,
Yibo