Re: [PATCH net] net/mlx5e: Fix NULL deref in PTP TX timestamp recovery warn

[Kalesh Anakkur Purayil]

On Thu, Oct 15, 2026 at 1:38 PM Tariq Toukan <tariqt@xxxxxxxxxx> wrote:

From: Carolina Jubran <cjubran@xxxxxxxxxx>

PTP SQs are allocated via mlx5e_ptp_alloc_txqsq(), which never sets
sq->channel. The excessive port timestamp delta recovery path
incorrectly used sq->channel->netdev for netdev_warn(), causing a NULL
pointer dereference. Use sq->netdev instead.

Fixes: 391dad2e686f ("net/mlx5e: Recover SQ on excessive PTP TX timestamp delta")
Signed-off-by: Carolina Jubran <cjubran@xxxxxxxxxx>
Reviewed-by: Alex Lazar <alazar@xxxxxxxxxx>
Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>

LGTM,

Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@xxxxxxxxxxxx> 

--

Regards,

Kalesh AP

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature