Re: [PATCH v8 07/12] dt-bindings: ufs: Add NXP S32N79 UFS host controller
From: Krzysztof Kozlowski
Date: Thu Oct 15 2026 - 04:40:50 EST
On Wed, Oct 14, 2026 at 04:58:30PM +0300, Larisa Ileana Grigore wrote:
> On 10/14/2026 2:10 PM, Krzysztof Kozlowski wrote:
> > On Tue, Oct 13, 2026 at 12:29:58PM +0200, Larisa Grigore wrote:
> > > + clocks:
> > > + maxItems: 1
> > > +
> > > + clock-names:
> > > + items:
> > > + - const: core
> >
> > I don't get why you added the clock-names.
> >
> Hello Krzysztof,
>
> The properties, `clock-names` and `operating-points-v2`, are needed to let
> the generic UFS platform code discover and manage the controller clock.
>
> `ufshcd_parse_operating_points()` uses `clock-names` to create the
You have only one clock, so my point is that UFS code is just poor, but
if that's the reason to mention its name, then just say that in commit
msg... or probably the ufs-common should be fixed.
Best regards,
Krzysztof