Re: [PATCH v2] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

[Julia Lawall]

On Wed, 14 Oct 2026, Jeremy Clifton wrote:

> On 10/14/26 7:46 PM, Julia Lawall wrote:
> >
> >
> > On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:
> >
> >> Previous commit removing a function definition did not remove the
> >> function prototype.
> >
> > Please use proper English.
> >
> > The commit 3228900f80c2 ("staging: greybus: Remove unused function
> > 'to_fw_mgmt_connection'") removing a function definition did not remove
> > the function prototype.
> >
> >>
> >> commit 3228900f80c2 ("staging: greybus: Remove unused function
> >> 'to_fw_mgmt_connection'")
> >>
> >> Function header declaration needs to be removed after definition
> >> removal.
> >
> > This is saying what you did.  It should be in the imperative:
> >
> > Remove the prototype.
> >
>
> "Remove the prototype." in the imperative has been changed.
>
> >> There is no definition of this function nor is there any place where it
> >> is called.
> >
> > Not sure this is needed, since the definition was removed previously.
>
> It's been removed.
>
> The next revision is sent.

I haven't received it.  Maybe the mailing list is slow again.

julia