Re: [PATCH] can: vcan: use per-CPU device stats

From: Marc Kleine-Budde

Date: Wed Oct 14 2026 - 19:54:01 EST


On 09.10.2026 00:30:36, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider.
>
> Critical: 0 · High: 1 · Medium: 0 (1) · Low: 2
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [High] The fix is incomplete.
> - [Low] The commit message gets the cause wrong: 'vcan does not implement
> get_num_tx_queues(), so rtnl_create_link() honours IFLA_NUM_TX_QUEUES'.
> - [Low] The patch fixes a syzbot-reported data race (it has Reported-by:
> syzbot+937a3a1fbfbc99d6fcaf and a Closes: link) that loses tx/rx…
>
> Pre-existing issues:
> - [Medium] This problem wasn't introduced by this patch, but the sibling
> driver vxcan (drivers/net/can/vxcan.c) has the same multi-queue stats…

pw-bot: cr

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |

Attachment: signature.asc
Description: PGP signature