Re: [PATCH] staging: greybus: Remove unused header declaration to_fw_mgmt_connection

From: Jeremy Clifton

Date: Wed Oct 14 2026 - 18:22:55 EST


On 10/14/26 1:13 PM, Julia Lawall wrote:


On Wed, 14 Oct 2026, Jeremy Dean Clifton wrote:

commit 3228900f80c2
("staging: greybus: Remove unused function 'to_fw_mgmt_connection'")

What is this?


This is the previous commit that did not remove the prototype of the function it removed. I'll include a sentence explaining what this commit info is here for.

Function header declaration needs to be removed after it's declaration.

it's -> its


This is a grammar and semantic error on my part. First, you are correct about 'its.'
Second, the word 'declaration' is truly not correct here. It would read better as 'definition.'

"Function header declaration needs to be removed after definition removal."

Submitting v2 with corrections.

Jeremy