Re: [PATCH v3 1/4] perf symbol: Fix symbol loading from libbfd

[Arnaldo Carvalho de Melo]

On Tue, Oct 13, 2026 at 02:02:15PM -0700, Namhyung Kim wrote:
> On Tue, Oct 13, 2026 at 03:35:24PM -0300, Arnaldo Carvalho de Melo wrote:
> > On Mon, Oct 12, 2026 at 04:59:34PM -0700, Namhyung Kim wrote:
> > > The dso__load() should return a positive number (number of symbols
> > > loaded) when it succeded to load symbols.  But dso__load_bfd_symbols()
> > > only returns 0 and it's hard to check if it actually loaded symbols or
> > > not.  Let's return the value of dso__has_symbol() and check it in
> > > dso__load() so that it can return 1 for success.
> > > 
> > > Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> > > Closes: https://lore.kernel.org/r/sashiko-outbox-162540@xxxxxxxxxx
> > > Fixes: eac9a4342e5447cad ("perf symbols: Try reading the symbol table with libbfd")
> > > Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> > 
> > Thanks, applied to perf-tools-next, for v7.4.
> 
> Thanks Arnaldo!
> 
> As you may know, this is from my other series on cleaning up symtab and
> binary types.  I'd like to land it as well so that I can continue
> working on the related issues.  There are some Sashiko feedback left,
> but I think they are either pre-existing bugs or known issues.

Right, its now at tmp.perf-tools-next, while I test build in my
container set, will push it to perf-tools-next next.

- Arnaldo