Re: [PATCH v11 04/13] block: introduce dma map backed bio type

[Pavel Begunkov]

On 10/14/26 14:15, Christoph Hellwig wrote:
> On Wed, Oct 14, 2026 at 12:02:02PM +0100, Pavel Begunkov wrote:
...>>   	case REQ_OP_DISCARD:
> > diff --git a/block/blk-mq.c b/block/blk-mq.c
> > index e929f94b25c7..1b7f8cbbda8b 100644
> > --- a/block/blk-mq.c
> > +++ b/block/blk-mq.c
> > @@ -3150,6 +3150,12 @@ void blk_mq_submit_bio(struct bio *bio)
> >   		goto queue_exit;
> >   	}
> >   
> > +	if (unlikely(op_is_dmabuf(bio->bi_opf) &&
> > +		bdev_has_integrity_csum(bio->bi_bdev))) {
> > +		bio_endio_status(bio, BLK_STS_NOTSUPP);
>
> Wrong indentation, conditions are never indented the same level as
> the following code block, even with the weirdest preferences.
>
> /me note the patch from Anuj on the list actually got this right..

I had to split Anuj's patch in two, should've butchered it
while hand applying. I'll follow up on that unless Jens
already applied the change.

> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
Pavel Begunkov