Re: [PATCH v2 13/13] media: sony-starvis2: Add support for IMX585

[Dave Stevenson]

Hi Jai

On Wed, 14 Oct 2026 at 14:50, Jai Luthra <jai.luthra@xxxxxxxxxxxxxxxx> wrote:
>
> Hi Dave,
>
> Thank you for the series.
>
> Quoting Dave Stevenson (2026-10-13 20:47:12)
> > IMX585 is an 8MPix Starvis 2 sensor, so add support for it.
> >
> > Signed-off-by: Dave Stevenson <dave.stevenson@xxxxxxxxxxxxxxx>
> > ---
> >  drivers/media/i2c/sony-starvis2.c | 302 ++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 302 insertions(+)
> >
> > diff --git a/drivers/media/i2c/sony-starvis2.c b/drivers/media/i2c/sony-starvis2.c
> > index 1ce2b86c57ac..c9a3dd4fe529 100644
> > --- a/drivers/media/i2c/sony-starvis2.c
> > +++ b/drivers/media/i2c/sony-starvis2.c
> [...]
> > +const struct starvis2_variant imx585_variant_def = {
> > +     .name = "imx585",
> > +     .id_reg = CCI_REG16_LE(0x5a1d),
> > +     .id_mask = 0x3ff,
> > +     .id_value = 0x259,
> > +     .active_area = {
> > +             .top = 0,
> > +             .left = 0,
> > +             .width = 3857,
> > +             .height = 2201,
> > +     },
>
> s/.active_area/.native_area
>
> Apologies for the drive-by comment, I just spotted this and thought it
> might result in a painful debug session.

Indeed.
Sashiko had already picked up on that and a couple of other things,
and Krzysztof has made comments on the binding patch, so I'm hoping to
get a v3 out today or tomorrow addressing them.
As mentioned on libcamera-devel earlier, there are a couple of other
changes required for imx585, so that may hold me up.

https://sashiko.dev/#/patchset/20261013-media-starvis2-v2-0-3670722d250a@xxxxxxxxxxxxxxx

> I'll do a proper review for the series, hopefully within this week :-)

Hold off for the v3, but that would be great.

Thanks
  Dave

> Thanks,
> Jai
>
> > +     .active_area = {
> > +             .top = 20,
> > +             .left = 0,
> > +             .width = 3856,
> > +             .height = 2180,
> > +     },
> > +     .pixel_rate = 594000000,
> > +     .pix_per_clk = 8,
> > +     .common_regs = imx585_common_regs,
> > +     .num_common_regs = ARRAY_SIZE(imx585_common_regs),
> > +     .vmax_default = 2250,
> > +     .hmax_min_link_freq = imx585_min_hmax_2lane,
> > +     .hmax_min_pixel_array = 550,
> > +};
> > +
>
> [...]