Re: [PATCH v3 2/3] platform: arm64: Add a driver for the EC found on ASUS Glymur machines

[Konrad Dybcio]

On 10/8/26 1:28 PM, Ilpo Järvinen wrote:
> On Wed, 23 Sep 2026, Konrad Dybcio wrote:
> 
>> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>>
>> Some Qualcomm Snapdragon X2 Elite (Extreme)-based ASUS laptops (at
>> least the Zenbook A14 and A16) expose a custom, somewhat
>> Qualcomm reference-derived EC interface. Introduce a driver to
>> communicate with said EC, allowing for fan speed reporting, keyboard
>> backlight setting and receiving of a number of miscellaneous sideband
>> events.

[...]


>> +	ret = asus_qcom_ec_write(ec, ASUS_QCOM_EC_RECM_OFFS, frame,
>> +				 ASUS_QCOM_EC_RECM_FRAME_LEN);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	ret = asus_qcom_ec_read(ec, ASUS_QCOM_EC_RECM_OFFS, resp,
>> +				ASUS_QCOM_EC_RECM_FRAME_LEN);
>> +	if (ret < 0)
>> +		return ret;
>> +
>> +	*out = (count == 2) ? get_unaligned_le16(resp) : resp[0];
> 
> Same problem here when it comes to sparse.
> 
> Does the ec really input be16 and output le16?

Yep, it really does..

Ack for the other comments

Konrad