Re: [PATCH DNM RFC 15/16] arm64: dts: qcom: sm8650: Drop required-opps

From: Dmitry Baryshkov

Date: Wed Oct 14 2026 - 10:33:51 EST


On Wed, Oct 14, 2026 at 02:19:15PM +0200, Konrad Dybcio wrote:
> From: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
>
> Now that the clock controllers take care of their power requirements,
> drop the required-opps that were only there because they previously
> hadn't.
>
> Assisted-by: LLM
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> ---
> DFS clocks (for QUPs) are left out for now, as they need some more
> code changes.
> ---
> arch/arm64/boot/dts/qcom/sm8650.dtsi | 46 ------------------------------------
> 1 file changed, 46 deletions(-)
>
> @@ -5057,22 +5039,18 @@ sdhc2_opp_table: opp-table {
>
> opp-19200000 {
> opp-hz = /bits/ 64 <19200000>;
> - required-opps = <&rpmhpd_opp_min_svs>;
> };
>
> opp-50000000 {
> opp-hz = /bits/ 64 <50000000>;
> - required-opps = <&rpmhpd_opp_low_svs>;
> };
>
> opp-100000000 {
> opp-hz = /bits/ 64 <100000000>;
> - required-opps = <&rpmhpd_opp_svs>;
> };
>
> opp-202000000 {
> opp-hz = /bits/ 64 <202000000>;
> - required-opps = <&rpmhpd_opp_svs_l1>;
> };
> };
> };


Can we then drop these OPP tables, which only have a HZ entry?

> @@ -5200,7 +5178,6 @@ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
> iommus = <&apps_smmu 0x40 0>;
>
> power-domains = <&gcc USB30_PRIM_GDSC>;
> - required-opps = <&rpmhpd_opp_nom>;

How do we ensure that we can access device registers? Is there a clock
(?) which now casts a vote, letting us access USB regs?

>
> snps,hird-threshold = /bits/ 8 <0x0>;
> snps,usb2-gadget-lpm-disable;

--
With best wishes
Dmitry