Re: [PATCH v5 0/9] platform/x86: hp-bioscfg: buffer handling fixes

[Ilpo Järvinen]

On Wed, 7 Oct 2026, Muhammad Bilal wrote:

> Buffer handling fixes for hp-bioscfg.
> 
> Patches 1-2 fix hp_get_string_from_buffer(), 3-5 the password
> handling, 6 the single line input check, 7-9 SPM and integer parsing.
>
> Changes in v5:
>  - Fix the multi-line comment style in patch 1 (Andy)
>  - Reword the changelog of patch 4 (Ilpo)
>  - Limit the scan in hp_enforce_single_line_input() to the string
>    instead of copying the input past its first NUL in patch 6 (Ilpo)
>  - Include array_size.h in patch 7 (Ilpo)
>  - Copy the token with kstrndup() in patch 8 (Ilpo)
> 
> Changes in v4:
>  - Add patches 4-9
> 
> Changes in v3:
>  - Drop Suggested-by: Andy Shevchenko from patch 2, tidy its includes
>    and declarations (Andy)
>  - Return -E2BIG instead of -ERANGE in patch 3 (Andy)
>  - Drop a blank line in the declarations in patch 1 (Andy)
> 
> Changes in v2:
>  - Split the hp_get_string_from_buffer() fix in two (Ilpo)
>  - Drop the lib/string_helpers patch, use @only of string_escape_mem()
>    instead (Andy)
>  - Add patch 3
> 
> Muhammad Bilal (9):
>   platform/x86: hp-bioscfg: fix OOB reads in hp_get_string_from_buffer()
>   platform/x86: hp-bioscfg: fix non-ASCII truncation in
>     hp_get_string_from_buffer()
>   platform/x86: hp-bioscfg: return -E2BIG from validate_password_input()
>   platform/x86: hp-bioscfg: allow clearing current_password
>   platform/x86: hp-bioscfg: fix off-by-one in password length check
>   platform/x86: hp-bioscfg: fix heap OOB in
>     hp_enforce_single_line_input()
>   platform/x86: hp-bioscfg: validate SPM state returned by firmware
>   platform/x86: hp-bioscfg: NUL-terminate the SPM auth token
>   platform/x86: hp-bioscfg: fix oops on short integer attribute buffer
> 
>  drivers/platform/x86/hp/hp-bioscfg/bioscfg.c  | 82 ++++++-------------
>  .../x86/hp/hp-bioscfg/int-attributes.c        |  7 +-
>  .../x86/hp/hp-bioscfg/passwdobj-attributes.c  | 18 ++--
>  .../x86/hp/hp-bioscfg/spmobj-attributes.c     |  9 +-
>  4 files changed, 53 insertions(+), 63 deletions(-)

I took patches other than patch 6. Some tweaks to the tags were made.

-- 
 i.