Re: [PATCH iwlwifi-next] wifi: iwlwifi: pcie: return a real errno from read_config32()
From: Johannes Berg
Date: Wed Oct 14 2026 - 09:08:25 EST
On Wed, 2026-10-14 at 18:13 +0530, Yogesh Gaur wrote:
> pci_read_config_dword() can also return a positive PCIBIOS_* error code
> (e.g. PCIBIOS_DEVICE_NOT_FOUND for a disconnected device), but
> iwl_trans_pcie_read_config32() passes it through unchanged and
> iwl_dump_ini_config_iter() only checks for ret < 0. The error is missed,
> so the loop keeps reading and stores 0xffffffff in the dump.
>
> Convert the return value with pcibios_err_to_errno().
>
This isn't incorrect, but is it a good idea? I'm not convinced, we might
still get some other parts of the dump vs. just aborting the entire
section at that point?
IOW, _why_ are you doing this? Do you have a problem with it? What is
that problem? Is it just a static checker/LLM complaint that you want to
fix?
johannes