[PATCH net 3/3] net/mlx5e: Expose CQE moderation mode on representors
From: Tariq Toukan
Date: Wed Oct 14 2026 - 08:54:41 EST
From: Yael Chemla <ychemla@xxxxxxxxxx>
commit bc541621f8ba ("net/mlx5e: Support ethtool cq mode") added
ETHTOOL_COALESCE_USE_CQE to the NIC ethtool ops but omitted it from
mlx5e_rep_ethtool_ops.supported_coalesce_params. The ethtool netlink
layer rejects any attempt to set cqe-mode-rx/tx on a representor
with EINVAL.
Add ETHTOOL_COALESCE_USE_CQE to mlx5e_rep_ethtool_ops.
mlx5e_ethtool_set_coalesce() already handles it correctly.
Fixes: bc541621f8ba ("net/mlx5e: Support ethtool cq mode")
Signed-off-by: Yael Chemla <ychemla@xxxxxxxxxx>
Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>
Signed-off-by: Tariq Toukan <tariqt@xxxxxxxxxx>
---
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
index 88a170e40bd9..4fb132a57bca 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
@@ -416,7 +416,8 @@ static u32 mlx5e_rep_get_rxfh_indir_size(struct net_device *netdev)
static const struct ethtool_ops mlx5e_rep_ethtool_ops = {
.supported_coalesce_params = ETHTOOL_COALESCE_USECS |
ETHTOOL_COALESCE_MAX_FRAMES |
- ETHTOOL_COALESCE_USE_ADAPTIVE,
+ ETHTOOL_COALESCE_USE_ADAPTIVE |
+ ETHTOOL_COALESCE_USE_CQE,
.op_needs_rtnl = ETHTOOL_OP_NEEDS_RTNL_SCHANNELS |
ETHTOOL_OP_NEEDS_RTNL_SRINGPARAM |
ETHTOOL_OP_NEEDS_RTNL_GLINK,
--
2.44.0