Re: [PATCH 01/13] ASoC: codecs: wm8990: Fix definition of right input PGA controls

From: Charles Keepax

Date: Wed Oct 14 2026 - 05:51:23 EST


On Wed, Oct 14, 2026 at 03:32:28PM +0900, HyeongJun An wrote:
> The right input PGA boost (R12MNBST, R34MNBST) and routing (R12MNB,
> R34MNB) bits are in Input Mixer4 (R42), not in Input Mixer3 (R41),
> where these controls write the left channel bits.
>
> Fixes: f10485e79882 ("[ALSA] ASoC: Add WM8990 driver")
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: HyeongJun An <sammiee5311@xxxxxxxxx>
> ---

Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>

Worth noting we don't seem to still have the datasheet for this
part internally, but this looks correct as per the header file
for the part.

Thanks,
Charles