Re: [PATCH 1/2] staging: rtl8723bs: remove remaining comparisons to true/false
From: Greg Kroah-Hartman
Date: Wed Oct 14 2026 - 00:58:55 EST
On Tue, Oct 13, 2026 at 04:41:28PM -0500, Zach Schneider wrote:
> Checkpatch reports "Using comparison to true/false is error prone"
> in rtw_wlan_util.c, hal_com.c, hal_intf.c, odm.c and
> ioctl_cfg80211.c. Replace "x == true" with "x" and "x == false"
> with "!x".
>
> bwmode_updated, bDisableSWChannelPlan and the HAL_DEF_MACID_SLEEP
> value are u8, and rtw_validate_ssid() returns u8, but they only ever
> hold true or false. ODM_RAStateCheck() returns bool. This does not
> change behavior.
>
> Assisted-by: LLM
> Signed-off-by: Zach Schneider <me@xxxxxxxxxxxxxxxxx>
> ---
> drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 2 +-
> drivers/staging/rtl8723bs/hal/hal_com.c | 2 +-
> drivers/staging/rtl8723bs/hal/hal_intf.c | 4 ++--
> drivers/staging/rtl8723bs/hal/odm.c | 2 +-
> drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
> 5 files changed, 6 insertions(+), 6 deletions(-)
Please read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
thanks,
greg k-h