Re: [PATCH] watchdog: sbsa_gwdt: stop the watchdog across the whole system-sleep transition

[David Cemin]

On Wed, Sep 16, 2026 at 05:18:34PM -0700, Guenter Roeck wrote:
> After thinking about it, I concluded that this is the wrong solution.
> First of all, it is a solution in search of a problem: Simply increasing
> the watchdog timeout to be safe would solve it.

Agreed, and sorry for the long silence. Please consider this patch
withdrawn. The resets described in the commit message are handled on
our side by running the watchdog with a timeout that covers the suspend
path, as you suggested, and the watchdog now stays armed throughout.

While doing that we found a second, unrelated problem on the same
platform that I want to mention because it touches the same driver.
sbsa_gwdt never calls watchdog_stop_ping_on_suspend(), so the keepalive
hrtimer of the core can still be armed when the system enters suspend.
On this platform that pending timer wakes the SoC a few seconds after
it enters suspend. Calling watchdog_stop_ping_on_suspend() from probe
removed the spurious wakeups over repeated suspend/resume cycles on two
boards. I will send that as a separate one-line patch. Your core series
from 9/29 (3/8 in particular, the _WDOG_SUSPENDED gate) closes the
remaining race in that path, so the two go together.

Thanks,
David