Re: [PATCH v3 6/6] watchdog: w83627hf_wdt: Report all initialization failures in probe

[Paul Louvel]

On Tue Oct 6, 2026 at 4:25 PM CEST, Tzung-Bi Shih wrote:
> On Sun, Oct 04, 2026 at 02:12:54PM +0200, Paul Louvel wrote:
>> @@ -549,12 +549,12 @@ static int wdt_probe(struct platform_device *pdev)
>>  		}
>>  
>>  		if (ret)
>> -			return ret;
>> +			return dev_err_probe(dev, ret, "failed to set watchdog timeout\n");
>>  	}
>>  
>>  	ret = devm_watchdog_register_device(dev, wdd);
>>  	if (ret)
>> -		return ret;
>> +		return dev_err_probe(dev, ret, "failed to register watchdog\n");
>
> Could this patch be split and squashed into the earlier patches in the
> series?

Sure.

Thanks,


-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

text:
Return-Path: <paul.louvel@xxxxxxxxxxx>
Delivered-To: paul.louvel@xxxxxxxxxxx
Received: from mail.galae.net ([172.22.1.253])
	by 9e7fea892943 with LMTP
	id 8JqdGEP3yGoblikAtaWaaQ
	(envelope-from <paul.louvel@xxxxxxxxxxx>)
	for <paul.louvel@xxxxxxxxxxx>; Fri, 09 Oct 2026 16:16:35 +0200
X-Original-To: paul.louvel@xxxxxxxxxxx
Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 7709111D70695;
	Fri,  9 Oct 2026 16:16:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim;
	t91555394; h=from:subject:date:message-id:to:cc:mime-version:content-type:
	 content-transfer-encoding:in-reply-to:references;
	bh=+6RbIlULZXUp8nBwvQCiDE791qoyPgtSl8eRr5UTXE0=;
	b=TqowhqpHs1FQoD3nipGC2madeVxQD3oc3Ng2IpD/U/sSYSKZ3g+vnXGZ4KRn4Re6lyQJ+m
	Cp1hBJXMjN8lYN4cARINL6LMT3H0tN/gw3lQr/nkeyna4iwi7cogoExl6UyD88FEFaUwUc
	WPPSs94sl4xDd6cAgg7xKZW8ELFldqi9A72hlZ2M3zcC9thyho/hQ8WfY+zcUs3xwQPYSH
	l/SDzO6rnpa9bNotmiZ7pi2YXR4If2E0981cxs5vI+WltPymbmIObao11ADXhb8bTnbVXj
	7/f+MOesjPFoaqEQCFQe9UgkrT0VtZqVS8FPfCV3K4M/h/K8p7guAcbuq3ATiQ=Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Fri, 09 Oct 2026 16:16:31 +0200
Message-Id: <DM0DDSTMFXRZ.29S5EXLMD7MHH@xxxxxxxxxxx>
Cc: "Wim Van Sebroeck" <wim@xxxxxxxxxxxxxxxxxx>, "Guenter Roeck"
 <linux@xxxxxxxxxxxx>, <linux-watchdog@xxxxxxxxxxxxxxx>,
 <linux-kernel@xxxxxxxxxxxxxxx>, "Thomas Petazzoni"
 <thomas.petazzoni@xxxxxxxxxxx>
Subject: Re: [PATCH v3 6/6] watchdog: w83627hf_wdt: Report all
 initialization failures in probe
From: "Paul Louvel" <paul.louvel@xxxxxxxxxxx>
To: "Tzung-Bi Shih" <tzungbi@xxxxxxxxxx>, "Paul Louvel"
 <paul.louvel@xxxxxxxxxxx>
X-Mailer: aerc 0.21.0-0-g5549850facc2
References: <20261004-w83627hf_wdt-improvements-v3-0-8e27b518595e@xxxxxxxxxxx> <20261004-w83627hf_wdt-improvements-v3-6-8e27b518595e@xxxxxxxxxxx> <asUE9eMeey5C42L4@xxxxxxxxxx>
In-Reply-To: <asUE9eMeey5C42L4@xxxxxxxxxx>
X-Last-TLS-Session-Version: TLSv1.3

On Tue Oct 6, 2026 at 4:25 PM CEST, Tzung-Bi Shih wrote:
> On Sun, Oct 04, 2026 at 02:12:54PM +0200, Paul Louvel wrote:
>> @@ -549,12 +549,12 @@ static int wdt_probe(struct platform_device *pdev)
>>  		}
>>  
>>  		if (ret)
>> -			return ret;
>> +			return dev_err_probe(dev, ret, "failed to set watchdog timeout\n");
>>  	}
>>  
>>  	ret = devm_watchdog_register_device(dev, wdd);
>>  	if (ret)
>> -		return ret;
>> +		return dev_err_probe(dev, ret, "failed to register watchdog\n");
>
> Could this patch be split and squashed into the earlier patches in the
> series?

Sure.

Thanks,


-- 
Paul Louvel, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com