Re: [PATCH] tty: hvc: dcc: Detect JTAG connection only on CPU core 0

[shatyuka]

Thanks for the review.

> Please use your real name in Signed-off-by.

Sorry about that. I'll send a v2 patch with my real name.

> > +/* Cached result of hvc_dcc_check() */
> > +static bool dcc_core0_available;
> 
> Shouldn't this be per-device?

There is only one HVC DCC instance, hvc0. No need to store this per
device.

> And how was this tested?

I tested this on an SMP system with no JTAG connected:

  # stty -F /dev/hvc0
  stty: can't open '/dev/hvc0': No such device

With the SMP migration issue present, the same command succeeds and
prints the terminal characteristics, because it falsely detects DCC
as available.

Best regards,
Jiannan Du