Re: [PATCH] xfs: make pNFS LAYOUTCOMMIT stable the way fdatasync does

[Christoph Hellwig]

On Tue, Oct 13, 2026 at 05:54:44PM +0900, Daejun Park via B4 Relay wrote:
> If preferred, I can factor the end of xfs_file_fsync() into a helper
> that both use, instead of exporting xfs_fsync_flush_log().

That feels like a bit of overkill, given that the shared code is
just two function calls.

> +int
>  xfs_fsync_flush_log(
>  	struct xfs_inode	*ip,
>  	bool			datasync,

... but maybe this helper should move to xfs_log.c and renamed to
something like xfs_log_force_inode?

Otherwise this looks good, thanks a lot!