Re: [PATCH v3 4/6] clk: qcom: Add Nord display clock controller support

[Dmitry Baryshkov]

On Fri, Jul 24, 2026 at 04:25:08PM +0530, Taniya Das wrote:
> Add support for the display clock controllers (DISPCC) on the
> Qualcomm Nord platform.
> 
> The platform includes two display clock controller instances,
> display0 and display1. Register support for both controllers.
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Reviewed-by: Shawn Guo <shengchao.guo@xxxxxxxxxxxxxxxx>
> Signed-off-by: Taniya Das <taniya.das@xxxxxxxxxxxxxxxx>
> ---
>  drivers/clk/qcom/Kconfig        |   11 +
>  drivers/clk/qcom/Makefile       |    1 +
>  drivers/clk/qcom/dispcc0-nord.c | 2004 +++++++++++++++++++++++++++++++++++++++
>  drivers/clk/qcom/dispcc1-nord.c | 2004 +++++++++++++++++++++++++++++++++++++++
>  4 files changed, 4020 insertions(+)
> 
> +
> +static struct clk_rcg2 mdss_0_disp_cc_mdss_mdp_clk_src = {
> +	.cmd_rcgr = 0x810c,
> +	.mnd_width = 0,
> +	.hid_width = 5,
> +	.parent_map = disp_cc_0_parent_map_8,
> +	.freq_tbl = ftbl_mdss_0_disp_cc_mdss_mdp_clk_src,
> +	.hw_clk_ctrl = true,
> +	.clkr.hw.init = &(const struct clk_init_data) {
> +		.name = "mdss_0_disp_cc_mdss_mdp_clk_src",
> +		.parent_data = disp_cc_0_parent_data_8,
> +		.num_parents = ARRAY_SIZE(disp_cc_0_parent_data_8),
> +		.flags = CLK_SET_RATE_PARENT,
> +		.ops = &clk_rcg2_shared_ops,

clk_rcg2_shared_no_init_park_ops

> +	},
> +};
> +
> +static struct clk_rcg2 mdss_0_disp_cc_mdss_pclk0_clk_src = {
> +	.cmd_rcgr = 0x80c4,
> +	.mnd_width = 8,
> +	.hid_width = 5,
> +	.parent_map = disp_cc_0_parent_map_2,
> +	.freq_tbl = ftbl_mdss_0_disp_cc_mdss_byte0_clk_src,
> +	.hw_clk_ctrl = true,
> +	.clkr.hw.init = &(const struct clk_init_data) {
> +		.name = "mdss_0_disp_cc_mdss_pclk0_clk_src",
> +		.parent_data = disp_cc_0_parent_data_2,
> +		.num_parents = ARRAY_SIZE(disp_cc_0_parent_data_2),
> +		.flags = CLK_SET_RATE_PARENT,

Here and in several similar places: No CLK_OPS_PARENT_ENABLE?

> +		.ops = &clk_pixel_ops,
> +	},
> +};
> +

-- 
With best wishes
Dmitry