Re: [PATCH] iio: accel: adxl345: select IIO_BUFFER and IIO_KFIFO_BUF

[Nuno Sá]

On Wed, Oct 07, 2026 at 09:34:16AM -0500, Alexis Bouzigues via B4 Relay wrote:
> From: Alexis Bouzigues <BouziguesAlexis@xxxxxxxxxxxxx>
> 
> Since the addition of FIFO watermark support, adxl345_core.c calls
> devm_iio_kfifo_buffer_setup() and iio_push_to_buffers(), but the
> ADXL345 Kconfig entry does not select IIO_BUFFER and IIO_KFIFO_BUF.
> Building with CONFIG_ADXL345_I2C=y and CONFIG_IIO_BUFFER=n fails to
> link:
> 
>   ld: drivers/iio/accel/adxl345_core.o: in function `adxl345_irq_handler':
>   adxl345_core.c:(.text+0x145c): undefined reference to `iio_push_to_buffers'
>   ld: drivers/iio/accel/adxl345_core.o: in function `adxl345_core_probe':
>   adxl345_core.c:(.text+0x1db6): undefined reference to `devm_iio_kfifo_buffer_setup_ext'
> 
> Add the missing selects on the hidden ADXL345 core symbol, as done for
> ADXL367, ADXL372 and ADXL380, so both the I2C and SPI front-ends are
> covered.
> 
> Fixes: cf04212d1fe7 ("iio: accel: adxl345: add FIFO with watermark events")
> Assisted-by: LLM
> Signed-off-by: Alexis Bouzigues <BouziguesAlexis@xxxxxxxxxxxxx>
> ---
> Add the buffer selections required by the ADXL345 FIFO support.
> The shared core symbol covers both I2C and SPI frontends.
> ---

Reviewed-by: Nuno Sá <nuno.sa@xxxxxxxxxx>

>  drivers/iio/accel/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/iio/accel/Kconfig b/drivers/iio/accel/Kconfig
> index 4094299e2ed8..fc130854af71 100644
> --- a/drivers/iio/accel/Kconfig
> +++ b/drivers/iio/accel/Kconfig
> @@ -61,6 +61,8 @@ config ADXL313_SPI
>  
>  config ADXL345
>  	tristate
> +	select IIO_BUFFER
> +	select IIO_KFIFO_BUF
>  
>  config ADXL345_I2C
>  	tristate "Analog Devices ADXL345 3-Axis Digital Accelerometer I2C Driver"
> 
> ---
> base-commit: 7b63ef2d55f24519e7e9e5f4d15dbea03f126e40
> change-id: 20261007-fix-adxl345-buffer-deps-review-69a214e05dca
> 
> Best regards,
> -- 
> Alexis Bouzigues <BouziguesAlexis@xxxxxxxxxxxxx>
> 
>