Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO

[Andy Shevchenko]

On Tue, Oct 13, 2026 at 09:50:07AM +0200, Joshua Crofts wrote:
> On Tue, 13 Oct 2026 00:28:25 +0300
> Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> > On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:
> > 
> > > Use dev_err_probe() when requesting the ldac GPIO fails. This
> > > avoids logging an error when the GPIO controller is not ready yet
> > > and the request returns -EPROBE_DEFER, and records the deferral
> > > reason. It also simplifies the error path.  
> > 
> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> > 
> > Although not sure if we need a Fixes tag as it might be an annoying (but quite
> > rare) case of flooding in the dmesg.
> 
> AFAIC this is a cleanup rather than a fix. dev_err_probe() conversions
> don't add Fixes tags.

I think it depends if one sees that problem IRL (see below examples),
but I am fine with or without Fixes tag for this.

59b991990a04 ("spi: hisi-kunpeng: Use dev_err_probe() for host registration failure")
5ff5505b9a2d ("drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found")
ad1abe476995 ("power: supply: cw2015: use dev_err_probe to allow deferred probe")

-- 
With Best Regards,
Andy Shevchenko