Re: [PATCH 0/4] media: atomisp: remove the circbuf library

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 11:07:49PM +0000, Rareș-Mihai Vladu wrote:
> Thanks to Andy for suggesting, in review of my earlier typedef
> patch [1], that I look at converting the custom circbuf code to
> circ_buf or kfifo.
> 
> While looking into it, it turned out that the circbuf API is only
> used by the local queue path, and ia_css_queue_local_init() has no
> callers, so that path is unused. The remote queues only need the
> descriptor and element layout shared with the SP firmware and a few
> small helpers.
> 
> So this series removes the unused local path, moves those few pieces
> into ia_css_queue_comm.h and drops base/circbuf/. Please let me know
> if you would prefer a different approach and I will rework it.
> 
> Patch 3 only moves code, apart from dropping OP___assert(), so I did
> not touch the existing style issues there.

Cool! That's what we prioritize for this driver (from people who don't possess
the HW), thanks a lot for doing this! I will look into the code later on.

> Compile-tested only, as I don't have the hardware.

-- 
With Best Regards,
Andy Shevchenko