Re: [PATCH v8 2/7] bus: mhi: Move Sahara protocol driver under MHI host client drivers
From: Kishore Batta
Date: Tue Oct 13 2026 - 03:27:56 EST
On 10/13/2026 2:13 AM, Uwe Kleine-König wrote:
On Mon, Oct 12, 2026 at 11:48:00PM +0530, Kishore Batta wrote:
#include <linux/devcoredump.h>Why? There isn't even a (new) usage of any *_device_id. There is a
#include <linux/firmware.h>
#include <linux/limits.h>
#include <linux/mhi.h>
+#include <linux/mod_devicetable.h>
mhi_device_id, please rely on linux/mhi.h to provide that. The main
effect of including linux/mod_devicetable.h is that the driver grows
many unneeded dependencies, so don't.
Best regards
Uwe
ACK. I will remove the redundant mod_devicetable.h include in the v9 version.