Re: [PATCH 21/24] ASoC: renesas: msiof: Fix msiof_close() being skipped on rollback

[Kuninori Morimoto]

Hi

> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> 
> snd_pcm_hw_constraint_integer() may return 1, which is then returned
> from msiof_open(). ASoC only marks the component as opened
> when .open() returns 0, so .close() can be skipped on rollback.
> 
> Return 0 explicitly on success.
> 
> Fixes: c61caec22820 ("ASoC: renesas: add MSIOF sound support")
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>
> ---

If so, we would like to have such comment to indicate such background,
because it is not intuitive for people.
Otherwise, someone (maybe me :) will return to the original code.

Thank you for your help !!

Best regards
---
Kuninori Morimoto