[PATCH 0/4] media: atomisp: remove the circbuf library

From: Rareș-Mihai Vladu

Date: Mon Oct 12 2026 - 19:08:50 EST


Thanks to Andy for suggesting, in review of my earlier typedef
patch [1], that I look at converting the custom circbuf code to
circ_buf or kfifo.

While looking into it, it turned out that the circbuf API is only
used by the local queue path, and ia_css_queue_local_init() has no
callers, so that path is unused. The remote queues only need the
descriptor and element layout shared with the SP firmware and a few
small helpers.

So this series removes the unused local path, moves those few pieces
into ia_css_queue_comm.h and drops base/circbuf/. Please let me know
if you would prefer a different approach and I will rework it.

Patch 3 only moves code, apart from dropping OP___assert(), so I did
not touch the existing style issues there.

Compile-tested only, as I don't have the hardware.

This supersedes the typedef patch [1].

[1] https://lore.kernel.org/all/20260918214132.1135549-1-vladurares@xxxxxxxxx/

Rareș-Mihai Vladu (4):
media: atomisp: sh_css_mipi: include assert_support.h directly
media: atomisp: queue: remove unused local queue support
media: atomisp: queue: move circbuf types and helpers to queue_comm.h
media: atomisp: remove unused circbuf library

drivers/staging/media/atomisp/Makefile | 2 -
.../base/circbuf/interface/ia_css_circbuf.h | 363 ------------------
.../circbuf/interface/ia_css_circbuf_comm.h | 56 ---
.../circbuf/interface/ia_css_circbuf_desc.h | 160 --------
.../atomisp/pci/base/circbuf/src/circbuf.c | 312 ---------------
.../runtime/queue/interface/ia_css_queue.h | 29 --
.../queue/interface/ia_css_queue_comm.h | 139 ++++++-
.../atomisp/pci/runtime/queue/src/queue.c | 112 +-----
.../pci/runtime/queue/src/queue_access.c | 1 -
.../pci/runtime/queue/src/queue_access.h | 4 +-
.../media/atomisp/pci/sh_css_internal.h | 2 +-
.../staging/media/atomisp/pci/sh_css_mipi.c | 1 +
12 files changed, 148 insertions(+), 1033 deletions(-)
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_comm.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/interface/ia_css_circbuf_desc.h
delete mode 100644 drivers/staging/media/atomisp/pci/base/circbuf/src/circbuf.c

--
2.43.0