Re: [PATCH 0/6 v1] perf test attr: Fix the re-enabled test

[Arnaldo Melo]

On October 12, 2026 7:40:07 PM GMT-03:00, Ian Rogers <irogers@xxxxxxxxxx> wrote:
>On Wed, Oct 7, 2026 at 1:31 AM Arnaldo Carvalho de Melo
><arnaldo.melo@xxxxxxxxx> wrote:
>>
>> On Tue, Oct 06, 2026 at 05:00:26PM -0700, Namhyung Kim wrote:
>> > On Tue, Oct 06, 2026 at 06:13:03PM +0200, Arnaldo Carvalho de Melo wrote:
>> > > From: Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>
>>  > The test passes with 'perf test -vv attribute' on x86_64.  The AMD
>> > > encodings come from the amd_pmu_event_map tables in
>> > > arch/x86/events/amd/core.c.
>> >
>> > On my machine, the current tmp.perf-tools-next which contains these
>> > changes fails like this.
>> >
>> >   $ tools/perf/perf test -v 82
>> >   ---- start ----
>> >   test child forked, pid 931585
>> >   /home/namhyung/project/linux/tools/perf/tests/shell/attr.sh: line 20: python: command not found
>> >   ---- end(-1) ----
>> >    82: Perf attribute expectations test                                                 : FAILED!
>> >
>> >   === Test Summary ===
>> >   Passed main tests : 0
>> >   Passed subtests   : 0
>> >   Skipped tests     : 0
>> >   Failed tests      : 1
>> >   List of failed tests:
>> >      82: Perf attribute expectations test
>> >
>> > The below patch fixes the problem.
>>
>> still without your patch:
>>
>> root@number:~# perf test attribute
>>  82: Perf attribute expectations t: Ok
>>
>>  === Test Summary ===
>>  Passed main tests : 1
>>  Passed subtests   : 0
>>  Skipped tests     : 0
>>  Failed tests      : 0
>>  root@number:~# grep "model name" -m1 /proc/cpuinfo
>>  model name      : AMD Ryzen 9 9950X3D 16-Core Processor
>>  root@number:~# uname -a
>>  Linux number 7.2.7-200.fc44.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Sep 21
>>  18:25:57 UTC 2026 x86_64 GNU/Linux
>>  root@number:~#
>>
>>  I reproduced the build failure in an ARM64 Debian Trixie machine,
>>  applying your patch to try again.
>
>For the change to use PYTHON:
>Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
>I think we can fix the attribute test expectations separately.


I fixed then already, will submit tomorrow morning: 

⬢ [acme@toolbx perf-tools-next]$ git log --oneline -22                     
 b8d6660fb3333fe9 (HEAD -> perf/alta-test-evsel-fix-and-mlock) perf tests: Mark the shell tests not mapping perf ring buffers                           
745ef567f0fe5705 perf tests: Mark the C tests mapping perf ring buffers
ebb8034d6627621f perf test: Take turns using the perf mlock budget in the mmaping tests                                                                 433379c85c0affc5 perf mutex: Add a robust, process-shared mutex initializer 
52277c8f4bc4a5f8 perf tests: Introduce a 'needs_mlock' suite flag
7be6c60f58acca20 perf test attr: State, spelled out in a line, why a test is skipped
2a6b500277a921d1 perf test attr: Ignore the group read_format bit the PMU count can remove                                                              392722445f2b0a15 perf test attr: Ignore the dummy tracking event and the terms it carries                                                               b4631e5b762de4a8 perf test attr: Accept either sample id bit perf asks for  
b2a70402b56b34e5 perf test attr: Introduce mask_bits(), generalizing hide_core_pmu_type()                                                               f6711283e99de095 perf evsel: Don't dump probe events to PERF_TEST_ATTR
13b60625f92619aa perf test attr: Ignore the core PMU type perf puts in 'config'                                                                         394bfd10f1923f0d perf evsel: Mark the event as supported when retrying an open
50a76fcdb7321c57 perf test attr: Relax group checking for ungrouped expectations
0887d3cc78ca9b69 perf test attr: Fix default stat metrics expectations      048fe0dc4cc566f0 perf test attr: Fix legacy event encodings in group tests
f1f3c53b46c5da4e perf test attr: Allow tests to require a core PMU          
75929770e7f9a907 perf test attr: Fix record dwarf sample_type expectation   
d4c243e294dee22c perf test attr: Fix wrong size expectation for events     
16e6b715c7ab376b perf test attr: Propagate the return value from the test to the wrapper                                                                74128ffa6d71a0ef perf test attr: Source setup_python.sh instead of calling python                                                                       1dc462fc21490767 (perf-tools-next.korg/perf-tools-next, five/perf-tools-next, acme/perf-tools-next) perf test: Add a test for perf timechart --tui      
⬢ [acme@toolbx perf-tools-next]$

- Arnaldo