Re: [PATCH] staging: iio: addac: adt7316: use dev_err_probe() for ldac GPIO

[Andy Shevchenko]

On Mon, Oct 12, 2026 at 03:35:30PM +0100, Nuno Sá wrote:
> On Sun, Oct 11, 2026 at 07:56:22PM +0100, Raffaele Tranfaglia via B4 Relay wrote:

> > Use dev_err_probe() when requesting the ldac GPIO fails. This
> > avoids logging an error when the GPIO controller is not ready yet
> > and the request returns -EPROBE_DEFER, and records the deferral
> > reason. It also simplifies the error path.

> Not sure what's Jonathan policy in here (or don't remember :)).
> Personally, I don't see much benefit on this kind of patches. I'm aware
> you might be eager to have something upstream but for staging I guess
> the real value is in having someone willing to really cleanup the driver
> so that we can take it out of staging (naturally that also means having
> HW or someone willing to test it).

This is a real fix for a (rare enough) problem. Without this it's possible
to get your dmesg flooded with the messages instead of the useful logs, so
I'm definitely in favour of taking it.

-- 
With Best Regards,
Andy Shevchenko