Re: [PATCH] ACPI: sysfs: Expose BDAT data region

[Rafael J. Wysocki (Intel)]

On Mon, Oct 12, 2026 at 8:52 PM Jamie Nguyen <jamien@xxxxxxxxxx> wrote:
>
> On Mon, Oct 12, 2026 at 11:15 AM Rafael J. Wysocki <rafael@xxxxxxxxxx> wrote:
> > Please see the Sashiko feedback on this patch:
> >
> > https://sashiko.dev/#/patchset/20261009232955.866131-1-jamien%40nvidia.com
> >
> > and let me know what you think about it.
>
> I agree with the Sashiko findings, and it looks like BERT and CCEL have
> the same problem, going back to commit 7dae6326ed76 ("ACPI / sysfs:
> Extend ACPI sysfs to provide access to boot error region").
>
> I'll send a v2 with a preparatory patch that moves sysfs_create_bin_file()
> and the kfree() on failure into acpi_table_data_init(), so it is fixed for
> all three tables, with the BDAT patch on top.
>
> The other concern in the report, the direct returns in the
> acpi_tables_sysfs_init() loop, was there before this patch, so I'd rather
> handle it separately if that's okay.

Sure, thanks!