Re: [PATCH 10/38] arm: dts: qcom: apq8060: Indent property data with tab

[Konrad Dybcio]

On 10/2/26 12:36 AM, Waqar Hameed wrote:
> Multiple property data on a newline should be indented with tabs.
> Found/fixed with dtfmt (Devicetree Source formatter).
> 
> Signed-off-by: Waqar Hameed <waqar.hameed@xxxxxxxx>
> ---
>  .../dts/qcom/qcom-apq8060-dragonboard.dts     | 28 +++++++++----------
>  1 file changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts b/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
> index 4dc63032cccb6..6ede4e5af4494 100644
> --- a/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
> +++ b/arch/arm/boot/dts/qcom/qcom-apq8060-dragonboard.dts
> @@ -966,25 +966,25 @@ dragon_ebi2_pins: ebi2-state {
>  		 */
>  		mux0-pins {
>  			pins =
> -			    /* "gpio39", CS1A_N this is not good to mux */

Here I see a possibility for improvement - we shouldn't really be
breaking lines at the assignment operator

Konrad

> -			    "gpio40", /* CS2A_N */
> -			    "gpio134"; /* CS0_N testpoint TP29 */
> +				/* "gpio39", CS1A_N this is not good to mux */
> +				"gpio40", /* CS2A_N */
> +				"gpio134"; /* CS0_N testpoint TP29 */
>  			function = "ebi2cs";
>  		};
>  
>  		mux1-pins {
>  			pins =
> -			    /* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */
> -			    "gpio123", "gpio124", "gpio125", "gpio126",
> -			    "gpio127", "gpio128", "gpio129", "gpio130",
> -			    /* EBI2_DATA_15 downto EBI2_DATA_0 data bus */
> -			    "gpio135", "gpio136", "gpio137", "gpio138",
> -			    "gpio139", "gpio140", "gpio141", "gpio142",
> -			    "gpio143", "gpio144", "gpio145", "gpio146",
> -			    "gpio147", "gpio148", "gpio149", "gpio150",
> -			    "gpio151", /* EBI2_OE_N */
> -			    "gpio153", /* EBI2_ADV */
> -			    "gpio157"; /* EBI2_WE_N */
> +				/* EBI2_ADDR_7 downto EBI2_ADDR_0 address bus */
> +				"gpio123", "gpio124", "gpio125", "gpio126",
> +				"gpio127", "gpio128", "gpio129", "gpio130",
> +				/* EBI2_DATA_15 downto EBI2_DATA_0 data bus */
> +				"gpio135", "gpio136", "gpio137", "gpio138",
> +				"gpio139", "gpio140", "gpio141", "gpio142",
> +				"gpio143", "gpio144", "gpio145", "gpio146",
> +				"gpio147", "gpio148", "gpio149", "gpio150",
> +				"gpio151", /* EBI2_OE_N */
> +				"gpio153", /* EBI2_ADV */
> +				"gpio157"; /* EBI2_WE_N */
>  			function = "ebi2";
>  		};
>  	};