Re: [PATCH net 1/2] vti: fix tunnel device use-after-free across async crypto resumption

From: Steffen Klassert

Date: Mon Oct 12 2026 - 06:27:02 EST


On Mon, Oct 12, 2026 at 05:07:43PM +0800, Qihang wrote:
> Hi Steffen,
>
> Thanks a lot for the guidance, much appreciated.
>
> Your three points make sense. For IPTFS, the skbs freed without the
> receive callback are the outer xfrm skbs, and it's only a handful of
> places in xfrm_iptfs.c -- a small shared helper would be cleaner than
> open-coding it at each site. The two xfrm_input changes (set family
> before the early drop, and hold the skb->dev reference unconditionally)
> look straightforward too.
>
> Would you prefer to handle the IPTFS and xfrm_input fixes yourself
> (Christian for IPTFS?), or should I send them as part of this series?
> Either way is fine with me.

I'll handle the full patchset, but Cc Chris on IPTFS.