Re: [PATCH v14 04/16] cxl: Embed decoder configuration in a standalone structure

[Srirangan Madhavan]

On 10/2/26 3:17 AM, Richard Cheng wrote:
> > +
>
> Hi Srirangan,
>
> Just a nit, from the first glance I would think this struct would match
> FW-config decoder setting, but in fact this is more a common linux representation
> of decoder config and state.
> E.g. id and flags.
>
> Also target-list/DPA skip values are handles separately.
>
> Maybe a short note would helpe readers understand this isn't a complete
> snapshot of FW-programmed registers.
>
> This is not a blocker.
>
> Reviewed-by: Richard Cheng <icheng@xxxxxxxxxx>

Ack. Added the note in v15.

--
Regards,
Srirangan