Re: [PATCH] net: can: cc770: don't discard the IRQ lookup error in probe

[Marc Kleine-Budde]

On 09.10.2026 18:55:56, Quchaosheng wrote:
> From: Chaosheng Qu <quchaosheng000406@xxxxxxx>
>
> cc770_platform_probe() collapses every failure of platform_get_irq()
> into -ENODEV:
>
> 	irq = platform_get_irq(pdev, 0);
> 	if (!mem || irq <= 0)
> 		return -ENODEV;
>
> That discards -EPROBE_DEFER, so a probe that has to wait for its
> interrupt controller is never retried and the device stays unbound.
>
> Return the lookup error unchanged, which is what the neighbouring CAN
> platform drivers already do (c_can_platform.c, flexcan-core.c,
> sja1000_platform.c). A device tree without an interrupt now reports
> -ENXIO rather than -ENODEV; the driver core treats those two the same
> way, so the outcome does not change.
>
> The memory resource is checked first and on its own, so a missing
> region no longer triggers an IRQ lookup that cannot succeed.
>
> Assisted-by: LLM
> Signed-off-by: Chaosheng Qu <quchaosheng000406@xxxxxxx>

Why did you send the patches 3 times?

Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature