Re: [PATCH] rtc: pcf8563: pass the driver data to the alarm interrupt handler

[Nobuhiro Iwamatsu]

Hi,

Thanks for your patch.

2026年10月5日(月) 8:57 Igor Velkov via B4 Relay <devnull+iav.iav.lv@xxxxxxxxxx>:
>
> From: Igor Velkov <iav@xxxxxx>
>
> pcf8563_irq() takes its dev_id as struct pcf8563, but probe still
> registers the interrupt with the i2c client. The handler then takes the
> regmap pointer from the wrong structure: the first alarm oopses, the
> level-low INT is never acknowledged, and the interrupt gets disabled as
> spurious.
>
> Only an RTC that has an interrupt (client->irq > 0) reaches this path.
>
> Fixes: 00f1bb9b8486 ("rtc: pcf8563: Switch to regmap")
> Cc: stable@xxxxxxxxxxxxxxx
> Assisted-by: LLM
> Signed-off-by: Igor Velkov <iav@xxxxxx>
> ---
> Tested on ODROID-HC4, 7.3-rc5, with the INT line wired to GPIOX_5 in the
> device tree: the alarm interrupt fires once, the alarm flag is cleared,
> no oops.
> ---
>  drivers/rtc/rtc-pcf8563.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Nobuhiro Iwamtasu <iwamatsu@xxxxxxxxxxx>

Best regards
  Nobuhiro