Re: [PATCH net] net/mlx4: shut down catas recovery timer during teardown

[Runyu Xiao]

Hi,

> This is fixing a patch from 2007.
>
> Did you hit this issue in reality, or just claimed by an AI tool?
>
> We need to have a very good justification to touch this old piece of
> code now, especially in stable.

I did not reproduce this issue on mlx4 hardware. It came from an AI-assisted
static audit, and I accepted the finding without establishing a failing
execution.

After rechecking the timer core, the interleaving in the commit message is
not sufficient: timer_delete_sync() waits for a running callback and retries
deletion, so poll_catas()'s own mod_timer() should be removed before
timer_delete_sync() returns. I have not established a separate concurrent
rearm path through mlx4_start_catas_poll() during this teardown, or observed
the callback accessing the mapping after it is unmapped.

I therefore cannot justify the reported bug or its Fixes: and Cc:
stable@xxxxxxxxxxxxxxx tags. I will withdraw this patch.

Sorry for the noise.

Thanks,
Runyu