Re: [RFC PATCH net-next v3 4/5] net: dsa: qca8k: flag QCA8337 internal CPU PHYs for SmartSpeed

[Andrew Lunn]

On Wed, Sep 23, 2026 at 11:58:56PM +0200, Yongzhao Chen wrote:
> Flag QCA8337 internal PHYs used as CPU links for SmartSpeed suppression.
> SmartSpeed is the Qualcomm PHY driver downshift feature configured in
> register 0x14.

As far as i can see, nothing configures register 0x14, so this is not
very useful.

Please look at other PHYs which support downshift. There is a tunable
for it. Also, the read_status is expected to return the real speed,
which often is not in BMSR, but in a vendor register.

Is there an errata which covers this?

It would be interesting to know if downshift is broken in general, or
only when used in switch integrated PHYs.

What might be possible here it to look at phydev->is_internal, rather
than add a flag, to differentiate switch internal PHYs and discrete
PHYs.

	Andrew