[PATCH v2] coresight: Check runtime PM resume result

From: Yuho Choi

Date: Wed Sep 23 2026 - 20:19:27 EST


coresight_get_ref() ignores the return value of pm_runtime_get_sync()
and reports success even when runtime resume fails. A path is then built
and the CoreSight device may be accessed while it remains powered off.

Use pm_runtime_resume_and_get() so a failed resume is reported and its
runtime PM usage reference is rolled back. Drop the module and device
references acquired before the resume attempt when it fails.

Fixes: 32b0707a4182 ("coresight: Add try_get_module() in coresight_grab_device()")
Signed-off-by: Yuho Choi <oss.patchbox@xxxxxxxxx>
---
Changes in v2:
- Point Fixes: at commit 32b0707a4182, which introduced coresight_get_ref()
with the unchecked pm_runtime_get_sync() (Anshuman Khandual)
- Switch to my oss.patchbox address

v1: https://lore.kernel.org/all/20260802232552.593435-1-dbgh9129@xxxxxxxxx/

drivers/hwtracing/coresight/coresight-core.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/hwtracing/coresight/coresight-core.c b/drivers/hwtracing/coresight/coresight-core.c
index 928488a216d4..c492f9082c46 100644
--- a/drivers/hwtracing/coresight/coresight-core.c
+++ b/drivers/hwtracing/coresight/coresight-core.c
@@ -843,7 +843,11 @@ static bool coresight_get_ref(struct coresight_device *csdev)
goto err_module;

/* Make sure the device is powered on */
- pm_runtime_get_sync(parent);
+ if (pm_runtime_resume_and_get(parent) < 0) {
+ module_put(drv->owner);
+ goto err_module;
+ }
+
return true;

err_module:

base-commit: f0100363d8c374bd8e9ea7c9ba02744f0b802ca4
--
2.43.0