Re: [PATCH v3 5/7] HID: hid-lenovo-go: normalize calibration failure status

[Derek J. Clark]

On September 23, 2026 2:14:58 PM PDT, Aditya Dash <mradityadash@xxxxxxxxx> wrote:
>Hi Derek,
>
>According to my observations, data[1] seems to give the correct status
>instead of data[0].
>
>device_type in cmd_rep seems to indicate the left or right controller, and
>data[0] the calibration device (gyro, joystick, or trigger).
>
>To validate that, I ran the left gyro calibration on my Legion Go 1
>and failed it on purpose.
>
>Here is the raw data alongside cmd_rep, its contents, and data array
>
>  raw        04 00 a0 02 03 01 02 01 00
>
>  cmd_rep    report_id   0x04
>             id          0x00
>             cmd         0xa0
>             sub_cmd     0x02
>             device_type 0x03 (left controller)
>
>  data[0]    0x01 (gyro)
>  data[1]    0x02 (failure)
>  data[2..3] 0x0001 (reason, little-endian)
>
>Reading data[0] as the status would report this failure as success.
>
>Therefore I lean towards keeping it as is.

 Okay, Sounds good.

Thanks,
Derek

>Thanks,
>Aditya