Re: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails
From: kernel test robot
Date: Wed Sep 23 2026 - 15:54:22 EST
Hi Coia,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net/main]
url: https://github.com/intel-lab-lkp/linux/commits/Coia-Prant/net-ethernet-stmmac-dwmac-rk-fix-bulk-clock-leak-when-the-PHY-clock-fails/20260920-014223
base: net/main
patch link: https://lore.kernel.org/r/20260919174223.2356964-1-coiaprant%40gmail.com
patch subject: [PATCH net] net: ethernet: stmmac: dwmac-rk: fix bulk clock leak when the PHY clock fails
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20260923/202609232146.QdgAwbzd-lkp@xxxxxxxxx/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260923/202609232146.QdgAwbzd-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202609232146.QdgAwbzd-lkp@xxxxxxxxx/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1168:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
1168 | return ret;
| ^
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1165:4: note: previous statement is here
1165 | if (ret)
| ^
>> drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:2: warning: non-void function does not return a value in all control paths [-Wreturn-type]
1177 | } else {
| ^
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1177:4: error: expected identifier or '('
1177 | } else {
| ^
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1189:2: error: expected identifier or '('
1189 | return 0;
| ^
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1190:1: error: extraneous closing brace ('}')
1190 | }
| ^
2 warnings and 3 errors generated.
vim +1177 drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
7ad269ea1a2b7d Roger Chen 2014-12-29 1152
7ad269ea1a2b7d Roger Chen 2014-12-29 1153 static int gmac_clk_enable(struct rk_priv_data *bsp_priv, bool enable)
7ad269ea1a2b7d Roger Chen 2014-12-29 1154 {
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1155 int ret;
7ad269ea1a2b7d Roger Chen 2014-12-29 1156
7ad269ea1a2b7d Roger Chen 2014-12-29 1157 if (enable) {
7ad269ea1a2b7d Roger Chen 2014-12-29 1158 if (!bsp_priv->clk_enabled) {
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1159 ret = clk_bulk_prepare_enable(bsp_priv->num_clks,
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1160 bsp_priv->clks);
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1161 if (ret)
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1162 return ret;
7ad269ea1a2b7d Roger Chen 2014-12-29 1163
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1164 ret = clk_prepare_enable(bsp_priv->clk_phy);
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1165 if (ret)
cb278e6780d874 Coia Prant 2026-09-20 1166 clk_bulk_disable_unprepare(bsp_priv->num_clks,
cb278e6780d874 Coia Prant 2026-09-20 1167 bsp_priv->clks);
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1168 return ret;
cb278e6780d874 Coia Prant 2026-09-20 1169 }
23c94d63a7e395 David Wu 2018-06-28 1170
5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1171) rk_configure_io_clksel(bsp_priv);
5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1172) rk_ungate_rmii_clock(bsp_priv);
2f2b60a0ec2826 David Wu 2022-08-30 1173
7ad269ea1a2b7d Roger Chen 2014-12-29 1174 mdelay(5);
7ad269ea1a2b7d Roger Chen 2014-12-29 1175 bsp_priv->clk_enabled = true;
7ad269ea1a2b7d Roger Chen 2014-12-29 1176 }
7ad269ea1a2b7d Roger Chen 2014-12-29 @1177 } else {
7ad269ea1a2b7d Roger Chen 2014-12-29 1178 if (bsp_priv->clk_enabled) {
5c1fc7cb81dfed Russell King (Oracle 2026-02-04 1179) rk_gate_rmii_clock(bsp_priv);
7f864458e9a6d2 Sebastian Reichel 2025-10-14 1180
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1181 clk_bulk_disable_unprepare(bsp_priv->num_clks,
ea449f7fa0bf3f Sebastian Reichel 2023-04-07 1182 bsp_priv->clks);
fecd4d7eef8b21 David Wu 2017-08-10 1183 clk_disable_unprepare(bsp_priv->clk_phy);
fecd4d7eef8b21 David Wu 2017-08-10 1184
7ad269ea1a2b7d Roger Chen 2014-12-29 1185 bsp_priv->clk_enabled = false;
7ad269ea1a2b7d Roger Chen 2014-12-29 1186 }
7ad269ea1a2b7d Roger Chen 2014-12-29 1187 }
7ad269ea1a2b7d Roger Chen 2014-12-29 1188
7ad269ea1a2b7d Roger Chen 2014-12-29 1189 return 0;
7ad269ea1a2b7d Roger Chen 2014-12-29 1190 }
7ad269ea1a2b7d Roger Chen 2014-12-29 1191
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki