Re: [PATCH v3] power: supply: cros_charge-control: adopt EC charge state on probe

[Matt DeVillier]

hi All,

Is anything else needed to move this patch forward?

Thanks,
Matt

On Sun, Aug 30, 2026 at 9:35 PM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
>
> On Fri, Aug 28, 2026 at 09:23:15AM -0500, Matt DeVillier wrote:
> > The driver previously always forced AUTO with no charge limits at
> > probe, which discarded sustainer thresholds and modes set by firmware
> > or firmware setup before the kernel loaded.
> >
> > For command versions that support GET (v2+), read the EC state into
> > the driver cache instead. Valid sustainer limits are adopted as AUTO
> > with those thresholds: while the sustainer is active the EC may report
> > IDLE or DISCHARGE as a transient hold/discharge step, which must not
> > be exposed as inhibit-charge or force-discharge. Sustainer off
> > (-1/-1) still maps to Linux "no limit" (0/100); other invalid limit
> > pairs are remapped the same way with a warning and pushed back to
> > the EC so the cache stays in sync.
> >
> > If GET fails, fall back to the previous defaults and SET them on the
> > EC. Command version 1 still cannot report state and keeps forcing a
> > well-known configuration.
> >
> > Signed-off-by: Matt DeVillier <matt.devillier@xxxxxxxxx>
> > Acked-by: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
>
> Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>