Re: [PATCH] serial: qcom-geni: avoid unused-function warning
From: Konrad Dybcio
Date: Wed Sep 23 2026 - 08:50:39 EST
On 9/15/26 10:04 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The qcom_geni_serial_poll_rx_fifo_locked() function is only
> used for console support, but defined outside of the #ifdef block:
>
> drivers/tty/serial/qcom_geni_serial.c:918:13: error: 'qcom_geni_serial_poll_rx_fifo_locked' defined but not used [-Werror=unused-function]
> 918 | static void qcom_geni_serial_poll_rx_fifo_locked(struct uart_port *uport)
>
> Move the function definition to a more appropriate place that
> avoids the warning.
>
> Fixes: 8200871327d1 ("serial: qcom-geni: Keep FIFO RX active during console TX")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad