Re: [PATCH v5 3/4] dt-bindings: pps: pps-gpio: document optional pinctrl states

[Rob Herring]

On Tue, Sep 22, 2026 at 02:46:40PM +0200, Rodolfo Giometti wrote:
> On Tue, Sep 22, 2026 at 10:30:50AM +0000, Eliav Farber wrote:
> > +    minItems: 1
> > +    items:
> > +      - const: default
> > +      - const: inactive
> 
> One observation while testing the series, entirely a devicetree call:
> dtschema derives maxItems from the items list, so this also caps
> pinctrl-names at two and fixes the order --

Yes, that's exactly what was said was needed here.

> 
>   "default", "inactive", "sleep"   ->  'is too long'
>   "default", "sleep"               ->  'inactive' was expected

Well, that's something different.

items:
  - const: default
  - enum: [ inactive, sleep ]
  - const: sleep

The common pinctrl-names schema should require unique names so 'sleep' 
can't be repeated.

> 
> I have no opinion on whether that matters for this binding, I just
> wanted it on the record.

We don't even require pinctrl properties to be documented. They are 
implicitly allowed, but good to document what users (drivers) 
expect/require.

Rob