Re: [PATCH] Revert "scripts/faddr2line: Combine three readelf calls into one"
From: Srikar Dronamraju
Date: Wed Sep 23 2026 - 05:44:42 EST
* Srikar Dronamraju <srikar@xxxxxxxxxxxxx> [2026-09-15 07:45:37]:
> * Josh Poimboeuf <jpoimboe@xxxxxxxxxx> [2026-09-14 12:00:26]:
Hi Josh,
> > > With the revert, we end up calling readelf three times but this should
> > > still be fine since calling faddr2line is a debug tool.
> > >
> > > Fixes: b8d9d9496c1e ("scripts/faddr2line: Combine three readelf calls into one")
> > > Signed-off-by: Srikar Dronamraju <srikar@xxxxxxxxxxxxx>
> >
> > Can you run
> >
> > bash -x scripts/faddr2line ./vmlinux need_active_balance+0x1d4/0x21c
> >
>
> + set -o errexit
> + set -o nounset
> + UTIL_SUFFIX=
> + [[ '' == '' ]]
Did you get a chance to look into this.
--
Thanks and Regards
Srikar Dronamraju