Re: [PATCH 2/3] cpufreq: mediatek: add mt6572 support

[Roman Vivchar]

On Wednesday, September 23rd, 2026 at 11:36 AM, AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx> wrote:

> On 9/23/26 09:23, Roman Vivchar via B4 Relay wrote:
> > From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> >
> > Add mt6572 SoC platform data for CPU frequency scaling.
> >
> > Signed-off-by: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> > ---
> >   drivers/cpufreq/mediatek-cpufreq.c | 9 +++++++++
> >   1 file changed, 9 insertions(+)
> >
> > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> > index f15135b2898b..615bccc77c98 100644
> > --- a/drivers/cpufreq/mediatek-cpufreq.c
> > +++ b/drivers/cpufreq/mediatek-cpufreq.c
> > @@ -737,6 +737,14 @@ static const struct mtk_cpufreq_platform_data mt2701_platform_data = {
> >   	.ccifreq_supported = false,
> >   };
> >
> > +static const struct mtk_cpufreq_platform_data mt6572_platform_data = {
> > +	.min_volt_shift = 100000,
> > +	.max_volt_shift = 200000,
> > +	.proc_max_volt = 1250000,
> > +	.sram_min_volt = 0,
> 
> Are you sure that there's no SRAM regulator on MT6572?

Yes. There's no 'sram' mention in the downstream code, neither mt6323 has sram
regulator.

> If there's none, there's no need to set sram_min_volt here,

Ack

> but if there is, you
> also need to set sram_max_volt.
> 
> The ccifreq_supported explicitly set to false is ok for human readability of the
> SoC features - that's also unneeded but keep it for the same of understanding
> what's going on with this SoC.
> 
> Cheers,
> Angelo
> 
> > +	.ccifreq_supported = false,
> > +};
> > +
> 
>

Best regards,
Roman