Re: [PATCH] staging: sm750fb: mark g_fbmode as const

[Ahmet Sezgin Duran]

On 9/23/26 1:55 AM, Iñaki Sobera Sotomayor wrote:
> The g_fbmode array of pointers is only used during module initialization
> to parse display options and is never modified. Marking both the pointers
> and the array const allows the compiler to place it in .rodata, which
> avoids accidental modifications and cleans up a checkpatch warning.
>
> Signed-off-by: Iñaki Sobera Sotomayor <inakisobera8@xxxxxxxxx>
> ---
>   drivers/staging/sm750fb/sm750.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 8b93bfeb2..c3f391cdd 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -12,7 +12,7 @@
>   static int g_hwcursor = 1;
>   static int g_noaccel __ro_after_init;
>   static int g_nomtrr __ro_after_init;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
>   static const char *g_def_fbmode = "1024x768-32@60";
>   static char *g_settings;
>   static int g_dualview __ro_after_init;

Did you compile this patch? While SM750 module is enabled?

Regards,
Ahmet Sezgin Duran